New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change es version check to support elasticsearch 8+ #4512
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
==========================================
+ Coverage 97.03% 97.04% +0.01%
==========================================
Files 301 300 -1
Lines 17817 17813 -4
==========================================
- Hits 17289 17287 -2
+ Misses 423 421 -2
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The change needs to be demonstrated with CI running successfully against v8. I added it to the matrix, but I think there is some infra issue where a started DB is not recognized by our script, needs investigation. |
a46720f
to
66e5693
Compare
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Which problem is this PR solving?
_type
field is incompatible in elasticsearch v8, and removing it allows me to successfully write to an index in elasticsearch v8.Short description of the changes