Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Benchmarks for V1 and V2 #5214

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

h4shk4t
Copy link
Contributor

@h4shk4t h4shk4t commented Feb 20, 2024

Which problem is this PR solving?

  • PR is on the issue 4869

Description of the changes

  • Add a benchmark test for both Jaeger V1 and V2 with a similar setup

Checklist

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
@h4shk4t h4shk4t requested a review from a team as a code owner February 20, 2024 13:29
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (e08f576) to head (4d99a31).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5214      +/-   ##
==========================================
- Coverage   95.64%   94.56%   -1.08%     
==========================================
  Files         325      336      +11     
  Lines       18619    19501     +882     
==========================================
+ Hits        17808    18442     +634     
- Misses        651      871     +220     
- Partials      160      188      +28     
Flag Coverage Δ
cassandra-3.x 24.94% <ø> (-0.64%) ⬇️
cassandra-4.x 24.94% <ø> (-0.64%) ⬇️
elasticsearch-5.x 21.66% <ø> (+1.79%) ⬆️
elasticsearch-6.x 21.65% <ø> (+1.80%) ⬆️
elasticsearch-7.x 21.78% <ø> (+1.78%) ⬆️
elasticsearch-8.x 21.88% <ø> (+1.79%) ⬆️
grpc-badger 19.11% <ø> (-0.38%) ⬇️
kafka 13.74% <ø> (-0.35%) ⬇️
opensearch-1.x 21.79% <ø> (+1.79%) ⬆️
opensearch-2.x 21.78% <ø> (+1.78%) ⬆️
unittests 92.39% <ø> (-0.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
@varshith257
Copy link
Contributor

@h4shk4t Are you able to complete this or ready to grab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants