Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Add support for Opensearch #5257

Merged
merged 6 commits into from Mar 21, 2024

Conversation

akagami-harsh
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Added OpenSearch support in jaeger-V2.
  • Reused the existing Elasticsearch factory for OpenSearch.

How was this change tested?

  • tested locally by running jaeger-v2 with newly added opensearch config-file.
  • Run the opensearch container:
docker run --rm --name opensearch -p 9200:9200 -e "discovery.type=single-node" opensearchproject/opensearch:1.3.0
  • Execute below to run jaeger-V2
go run -tags=ui ./cmd/jaeger/. --config ./cmd/jaeger/config-opensearch.yaml

Checklist

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh requested a review from a team as a code owner March 7, 2024 16:46
@akagami-harsh
Copy link
Member Author

I haven't added tests for OpenSearch yet, as it reuses the Elasticsearch factory. Or should i add specific tests for opensearch too?

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (29e3fe8) to head (b822adf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5257      +/-   ##
==========================================
- Coverage   95.07%   95.06%   -0.02%     
==========================================
  Files         340      340              
  Lines       16604    16610       +6     
==========================================
+ Hits        15787    15791       +4     
- Misses        628      630       +2     
  Partials      189      189              
Flag Coverage Δ
badger 13.26% <ø> (ø)
cassandra-3.x 26.44% <ø> (ø)
cassandra-4.x 26.44% <ø> (ø)
elasticsearch-5.x 21.70% <ø> (-0.07%) ⬇️
elasticsearch-6.x 21.68% <ø> (-0.07%) ⬇️
elasticsearch-7.x 21.77% <ø> (-0.09%) ⬇️
elasticsearch-8.x 21.87% <ø> (-0.06%) ⬇️
grpc 10.91% <100.00%> (+0.03%) ⬆️
kafka 14.73% <ø> (ø)
opensearch-1.x 21.78% <ø> (-0.06%) ⬇️
opensearch-2.x 21.77% <ø> (-0.09%) ⬇️
unittests 92.29% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added v2 changelog:exprimental Change to an experimental part of the code labels Mar 7, 2024
akagami-harsh and others added 4 commits March 9, 2024 21:17
Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@yurishkuro yurishkuro merged commit db8c04c into jaegertracing:main Mar 21, 2024
37 checks passed
@akagami-harsh akagami-harsh deleted the Opensearch branch March 21, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants