Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed Version 4.0.0 #51

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Proposed Version 4.0.0 #51

wants to merge 6 commits into from

Conversation

A9G-Data-Droid
Copy link

@A9G-Data-Droid A9G-Data-Droid commented Oct 27, 2023 •
edited

This goes much farther than my first PR, into the realm of breaking changes.

@A9G-Data-Droid
Use official VS gitignore
611878a 
https://github.com/github/gitignore/blob/main/VisualStudio.gitignore

 - Update test to supported .net6
 - Update nugets
@A9G-Data-Droid
One netstandard2.0 library
2c51713 
 - The lowest framework supported is 4.6.2
 - Add CodePages to netstandard project to support net6
 - net6 tests prove that this closes jaime-olivares#43
@A9G-Data-Droid
Proposed Version 4
c41f9dc 
 - One class per file
 - Make public fields properties
 - Do not use Microsoft namespaces!
 - C# naming conventions
 - Implement async
 - Add ExtractToFolder
 - Always put Dispose in Finally or using
 - Refactor and cleanup
@A9G-Data-Droid
Closing issues
e724878 
 - Closes jaime-olivares#39
 - Closes jaime-olivares#22
 - Closes jaime-olivares#37
@A9G-Data-Droid
Fix Nuget Package name
bbd9d6c 
 - Extract to directory will overwrite
@A9G-Data-Droid
Do not attempt to unzip directories as files
135b298 
 - Closes jaime-olivares#48
 - Make sync and async behavior the same
@A9G-Data-Droid
Copy link
Author

Now closes #48

@jaime-olivares
Copy link
Owner

Thanks @A9G-Data-Droid,
Those are indeed a lot of changes in a single PR, not possible to select individual ones.
I will review asap.
--Jaime.

@andreoromera
Copy link

Any update on this?

@A9G-Data-Droid
Copy link
Author

A9G-Data-Droid commented Jun 3, 2024 •
edited

It might be easier to review and merge #50 first, as this one is building upon that same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@A9G-Data-Droid @jaime-olivares @andreoromera