add BeanConfigurator.priority #532
Conversation
|
This alters the Portable Extensions API, so I'm not adding Graeme for review. The only relationship to Lite is that this addition will make it possible to completely implement the Build Compatible Extensions API on top of Portable Extensions. |
There was a problem hiding this comment.
Added small comment, otherwise LGTM.
Notably, this already exists in Weld, see https://github.com/weld/api/blob/master/weld/src/main/java/org/jboss/weld/bootstrap/event/WeldBeanConfigurator.java#L135-L144
api/src/main/java/jakarta/enterprise/inject/spi/configurator/BeanConfigurator.java
Show resolved
Hide resolved
This is to allow setting a priority for synthetic beans created using `BeanConfigurator`. I briefly considered if `priority` should be added to `BeanAttributesConfigurator` as well, but that would have a ripple effect. It also doesn't reflect the present reality. A custom `Bean` implementation can be added a priority by implementing the `Prioritized` interface. Adding only `BeanConfigurator.priority` is a perfect mirror of that in the configurator API.
Ladicek
force-pushed
the
synth-bean-priority
branch
from
114543f
to
7da45de
Compare
|
@Ladicek Btw we should create a tracking issue for TCK test or send one right away (we could probably use existing weld test) so that we don't forget. |
|
I added a TCK issue |
|
Whoops! Yes, good point. @manovotn can you please point me to the existing Weld test? I'll try submitting a PR to the TCK. |
This is to allow setting a priority for synthetic beans created
using
BeanConfigurator.I briefly considered if
priorityshould be added toBeanAttributesConfiguratoras well, but that would havea ripple effect. It also doesn't reflect the present reality.
A custom
Beanimplementation can be added a priorityby implementing the
Prioritizedinterface. Adding onlyBeanConfigurator.priorityis a perfect mirror of thatin the configurator API.