Decide on other mentions of Full-only concepts in the CDI Lite spec p… #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
commented
Oct 11, 2021
Ladicek
reviewed
Oct 11, 2021
Ladicek
reviewed
Oct 11, 2021
Ladicek
reviewed
Oct 11, 2021
manovotn
force-pushed
the
issue489
branch
3 times, most recently
from
c493a2f
to
2219e21
Compare
|
@Ladicek thanks for comments, all of them should be addressed now. |
|
@Ladicek are you fine with the state of this PR? |
Ladicek
reviewed
Oct 12, 2021
Ladicek
reviewed
Oct 12, 2021
|
Sorry it took me so long. These are the final comments I have. |
|
@Ladicek addressed both comments |
Ladicek
approved these changes
Oct 12, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…art.
Fixes #489
This PR moves some more CDI Full mentions into their respective specification sections.