Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BeanManager treatment in CDI Lite #547

Merged
merged 1 commit into from Oct 21, 2021
Merged

Change BeanManager treatment in CDI Lite #547

merged 1 commit into from Oct 21, 2021

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Oct 21, 2021

Previously, the specification downright disallowed obtaining
a BeanManager in CDI Lite. This makes portability from CDI Full
to CDI Lite harder, which also manifests in the CDI TCK.

Wit this commit, CDI Lite applications may obtain a BeanManager,
but may only call methods inherited from BeanContainer.

@Ladicek
Change BeanManager treatment in CDI Lite
3b37d17 
Previously, the specification downright disallowed obtaining
a `BeanManager` in CDI Lite. This makes portability from CDI Full
to CDI Lite harder, which also manifests in the CDI TCK.

Wit this commit, CDI Lite applications may obtain a `BeanManager`,
but may only call methods inherited from `BeanContainer`.
@Ladicek
Copy link
Contributor Author

Ladicek commented Oct 21, 2021

I'm specifically adding @graemerocher as a reviewer for higher visibility. I think this is pretty straightforward to implement -- if you have a BeanContainer, implementing a BeanManager on top of it is simple: delegate BeanContainer methods to the BeanContainer, and throw an exception from other methods.

manovotn
manovotn approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is going to save us some headaches in TCKs.

@Ladicek Ladicek merged commit 984b274 into jakartaee:master Oct 21, 2021
@Ladicek Ladicek deleted the beanmanager branch October 21, 2021 09:25
@Ladicek Ladicek added the Lite Related to CDI Lite label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
Lite Related to CDI Lite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ladicek @graemerocher @manovotn