Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the session scope to CDI Full #577

Merged
merged 1 commit into from Dec 8, 2021

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Dec 7, 2021

When I was reviewing the remaining CDI 4.0 work, I realized we kept the session scope in CDI Lite. I believe it should be moved to CDI Full, because:

Hence, I'm proposing this PR to remove the session scope from Lite. It stays in Full.

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@manovotn
Copy link
Contributor

manovotn commented Dec 8, 2021

Going to merge this, if @graemerocher has any comments/remarks, feel free to leave them here and we can reopen the discussion.

@manovotn manovotn merged commit 12047ee into jakartaee:master Dec 8, 2021
@Ladicek Ladicek deleted the move-session-scope-to-full branch December 8, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants