Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid parameter combinations in @Enhancement and @Registration meth… #581

Merged
merged 1 commit into from Dec 8, 2021

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Dec 8, 2021

…ods should be treated as definition errors.

As I pointed out in jakartaee/cdi-tck#329, I think we should handle these cases as definition errors.

…ods should be treated as definition errors.
@manovotn manovotn requested a review from Ladicek December 8, 2021 14:28
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me, though the difference between definition errors and deployment problems is kinda blurry in case of extensions (and especially Build Compatible Extensions, where there's no way for the extension to produce a definition error, unlike Portable Extensions).

@manovotn
Copy link
Contributor Author

manovotn commented Dec 8, 2021

DefinitionException (thrown in case of definition error) indicated that it's developer's error which is IMO the case here.
See https://github.com/eclipse-ee4j/cdi/blob/master/api/src/main/java/jakarta/enterprise/inject/spi/DefinitionException.java#L25-L29

(and especially Build Compatible Extensions, where there's no way for the extension to produce a definition error ....

Not sure I follow, there is little difference in producing definition versus deployment error for Build Compatible Extensions. Or am I missing something?

@Ladicek
Copy link
Contributor

Ladicek commented Dec 8, 2021

No, you're not. Sorry for confusion, the remark was only tangentially related.

@manovotn manovotn merged commit 95a3838 into jakartaee:master Dec 8, 2021
@manovotn manovotn deleted the changeInvalidBceTreatment branch December 8, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants