Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure CDI and BuildServicesResolves both guard against repeated i… #619

Merged
merged 1 commit into from Jun 6, 2022

Conversation

manovotn
Copy link
Contributor

…nvocations of set method

Fixes #618

Both APIs now behave equally and guard firstly against null value and then against attempts to re-set previously configured value.

This is potentially breaking change and as such should only be part of next bigger release.

@manovotn manovotn requested a review from Ladicek May 25, 2022 14:52
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starksm64
Copy link
Contributor

So the question is do we want to plan for a 4.1 release, or go to 5.0. Both require a creation review plan, so it is really just a question of what the scope of planned changes might be.

@manovotn
Copy link
Contributor Author

So the question is do we want to plan for a 4.1 release, or go to 5.0. Both require a creation review plan, so it is really just a question of what the scope of planned changes might be.

TBF, I don't know.
I'd say we only need a major bump if we were planning some big breaking change. The current list of issues consists mostly of smaller items.
That being said, it might be worth asking people during the meeting (or two) and/or through mailing list for their ideas on next version and capture it in dedicated tracking issue. From there we might get a hang of what the list of possible changes looks like and decide. WDYT @starksm64 @Ladicek?

@Ladicek
Copy link
Contributor

Ladicek commented May 27, 2022

I agree we should first put together a plan for the next version, and its version number will naturally follow from the content of that plan.

@manovotn
Copy link
Contributor Author

manovotn commented Jun 6, 2022

I am going to merge this.
In case we need a service release, we can always make a dedicated branch and cut off required commits.

@manovotn manovotn merged commit 82ec5d7 into jakartaee:master Jun 6, 2022
@manovotn manovotn deleted the issue618 branch June 6, 2022 09:28
@Ladicek Ladicek added this to the CDI 4.1 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDI.setCDIProvider has different behavior than the javadoc states
3 participants