Introduce BeanContainer.getContexts() to be able to get hold of all context objects, even if inactive #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext objects, even if inactive
Ladicek
approved these changes
Jul 18, 2022
Emily-Jiang
reviewed
May 23, 2023
| * {@linkplain jakarta.enterprise.context scope}. | ||
| * | ||
| * @param scopeType the {@linkplain jakarta.enterprise.context scope}; must not be {@code null} | ||
| * @return immutable collection of {@linkplain Context context objects}; never {@code null}, but may be empty |
There was a problem hiding this comment.
Suggested change
| * @return immutable collection of {@linkplain Context context objects}; never {@code null}, but may be empty | |
| * @return an immutable collection of {@linkplain Context context objects}; never {@code null}, but may be empty |
|
Need to file a TCK tracking issue now. EDIT: actually a TCK tracking issue already exists: jakartaee/cdi-tck#396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628
I will also create tracking TCK issue.
Also, I've checked in Weld that this is indeed trivial to implement as all
BeanManagerinstances hold references to all contexts anyway.