Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/README #643

Merged
merged 3 commits into from Jan 3, 2023
Merged

docs/README #643

merged 3 commits into from Jan 3, 2023

Conversation

ekimike
Copy link
Contributor

@ekimike ekimike commented Dec 24, 2022

Before pointing out that the Ruby 2.x version could be the only one for running Jekyll, I think it is better to put it as a recommendation instead of a fact because doing fast research, it seems Jekyll could work with Rubby 3.x, but I didn't test it.

The second change relates to the URL, just added the final part.

@ekimike ekimike mentioned this pull request Dec 27, 2022
docs/README.md Outdated Show resolved Hide resolved
@manovotn
Copy link
Contributor

manovotn commented Jan 2, 2023

it seems Jekyll could work with Rubby 3.x, but I didn't test it.

I think I did try with 3.x some time ago and failed to make it work in current setup but I don't recall the details.
Phrasing it as recommendation is IMO fine.

@manovotn manovotn linked an issue Jan 2, 2023 that may be closed by this pull request
@ekimike
Copy link
Contributor Author

ekimike commented Jan 3, 2023

Could you check this again, please?

docs/README.md Outdated Show resolved Hide resolved
@Ladicek Ladicek merged commit 314049c into jakartaee:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs/README.md outdated
3 participants