Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc for createInstance validity #689

Merged
merged 1 commit into from Aug 14, 2023

Conversation

Azquelt
Copy link
Contributor

@Azquelt Azquelt commented Aug 10, 2023

The spec and TCK assert that BeanContainer.createInstance() must not be called before the AfterDeploymentValidation event is fired.

Correct some Javadoc which was inconsistent.

Fixes #688

The spec and TCK assert that BeanContainer.createInstance() must not be
called before the AfterDeploymentValidation event is fired.

Correct some Javadoc which was inconsistent.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
@manovotn manovotn requested a review from Ladicek August 10, 2023 16:44
@Ladicek Ladicek added this to the CDI 4.1 milestone Aug 14, 2023
@Ladicek Ladicek merged commit bbfd0c4 into jakartaee:master Aug 14, 2023
3 of 4 checks passed
@Azquelt Azquelt deleted the createinstance-javadoc branch August 16, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in when BeanContainer.createInstance() may be called
3 participants