Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to Bean and Event Assignability API #742

Merged
merged 1 commit into from Jan 13, 2024

Conversation

Azquelt
Copy link
Contributor

@Azquelt Azquelt commented Jan 12, 2024

Follow up to #700 with a few things I noticed while writing TCKs in jakartaee/cdi-tck#526:

  • use code tags for true and false
  • consistently use @ with annotation classes in javadoc
  • fix wrong method name in spec
  • add anchor name to spec
  • no implied Default qualifier for events
  • Change "beans and observers" to "beans and events" in spec for consistency

Relates to issue #498

* use code tags for true and false
* consistently use @ with annotation classes
* fix wrong method name in spec
* add anchor name to spec
* no implied Default qualifier for events
* Change "beans and observers" to "beans and events" in spec for
  consistency
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no implied Default qualifier for events

Ah, good catch, thank you.
The rest are nice quality of life changes; appreciate having another pair of eyes double checking for these changes!

@manovotn manovotn requested a review from Ladicek January 12, 2024 19:38
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@manovotn manovotn merged commit d2ae8ff into jakartaee:main Jan 13, 2024
5 checks passed
@Azquelt Azquelt deleted the assignability-updates branch January 15, 2024 10:26
@Ladicek Ladicek added this to the CDI 4.1 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants