Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix license headers and some other small things in the website #773

Merged
merged 1 commit into from Feb 26, 2024
Merged

fix license headers and some other small things in the website #773

merged 1 commit into from Feb 26, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Feb 26, 2024

No description provided.

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 26, 2024 •
edited

CC @Azquelt

I had to move the license headers into the Jekyll front matter block, as YAML comments, otherwise Jekyll would not notice the front matter at all.

@Ladicek Ladicek mentioned this pull request Feb 26, 2024
Merged
Azquelt
Azquelt approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I hadn't noticed that the .html and .md files are not just html and markdown.

@manovotn manovotn merged commit 5cd17de into jakartaee:main Feb 26, 2024
4 of 5 checks passed
@Ladicek Ladicek deleted the fix-license-headers-in-docs branch February 27, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azquelt Azquelt Azquelt approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ladicek @Azquelt @manovotn