Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Initial dotnet core port #764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

latop2604
Copy link
Collaborator

@latop2604 latop2604 commented Nov 23, 2017

All AD stuff was disabled.
Some view are still not converted to aspnetcore.

My main setup is composed of SqlServer, Cookie Auth, internal user database.
I quickly try to use Sqlite. Be not so much.

Most custom html helpers (like WebGrid) are not available in dotnetcore. (or not found)

I will amend this commit to preserve a relative clean history.

Status

Ported

  • Entity framework
  • Sql Server
  • SqLite
  • Controllers
  • Git Controllers
  • Mvc Attributes
  • View (not all) + missing components like CheckBoxListFor or WebGrid)
  • Cookie Auth
  • Federation Auth
  • Windows Auth
  • Repository Browser
  • Ad stuff (the main part)
  • ...

Tested (quickly)

  • Windows Env
  • Linux Env
  • Entity framework
  • Sql Server (From empty database)
  • Repository Controller
  • Git Controllers
  • Cookie Auth
  • Repository Browser
  • ...

Misc :

I'm looking for an alternative to WebGrid and CheckBoxListFor
AD stuff use System.DirectoryServices nuget and only support Windows. corefx/24909
Unit Test ???

@willdean
Copy link
Collaborator

@latop2604 This is a huge amount of work, I am very impressed, but I don't want to give you unrealistic expectations about this getting merged into Bonobo.

I don't think Bonobo is stable or well-tested enough (in terms of automated test) to risk a change like this, particularly as the difficult auth scenarios (AD, etc) are so difficult to test, and they're going to be the ones which are hardest in Core anyway.

You might want to discuss this with @jakubgarfield, but I think you may be better making a fork of some kind.

@latop2604
Copy link
Collaborator Author

Yes of course.
I created this pull request just for information.
It's still fun to do.

In the future, we can create a specific (experimental) branch. If someone want to contribute to. But not now.

@latop2604 latop2604 force-pushed the netcore branch 4 times, most recently from 082ec2f to 062638d Compare December 6, 2017 23:32
@softlion
Copy link

softlion commented Sep 21, 2018

This port is the best bet as the original author seems to have disappear. Btw AD is easy to test using Azure Ad server. And the nuget works perfectly.

@Pireax Pireax mentioned this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants