Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: don't warn on useless conversions when the count value is already a usize #206

Closed
wants to merge 2 commits into from
Closed

Fix: don't warn on useless conversions when the count value is already a usize #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa61f4
nit: fix doc comment that applied to use and not module
poliorcetics Jun 21, 2023
9df9189
fix: don't warn on useless conversions when the value is already a usize
poliorcetics Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions binrw_derive/src/binrw/codegen/mod.rs
View file
Open in desktop
Expand Up @@ -325,6 +325,7 @@ fn directives_to_args(field: &StructField, stream: IdentStr) -> TokenStream {
quote_spanned_any! {count.span()=>
count: {
let #TEMP = #count;
#[allow(clippy::useless_conversion)]
usize::try_from(#TEMP).map_err(|_| {
extern crate alloc;
#BIN_ERROR::AssertFail {
Expand Down
2 changes: 1 addition & 1 deletion binrw_derive/src/binrw/codegen/sanitization.rs
View file
Open in desktop
@@ -1,4 +1,4 @@
///! Utilities for helping sanitize macro
//! Utilities for helping sanitize macro
use crate::util::{from_crate, ident_str};
use proc_macro2::Ident;
use quote::format_ident;
Expand Down