Remove PureAttribute from non pure Methods #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 18, 2013 14:14
DeepEquals returns true/false, ShouldDeepEqual throws a descriptive exception if objects aren't equal.
…jamesfoster#34) * Add net461 target to work around ValueTuple missing method exceptions See dotnet/standard#567 for context here. I ran into this while using `SetComparison.Compare(...)` which is all public DeepEquals API. This manifests itself like so: ```c# [{System.MissingMethodException}: 'Method not found: 'System.ValueTuple`2<DeepEqual.ComparisonResult,DeepEqual.IComparisonContext> DeepEqual.SetComparison.Compare(DeepEqual.IComparisonContext, System.Object, System.Object)'.'] ```
* NaN handling * Update FloatComparisonTests.cs Revert loss of alignment. * Update FloatComparison.cs Fix indentation after file scoped namespaces Co-authored-by: silver-bytes <silver-bytes@outlook.com> Co-authored-by: James Foster <james.mdb@gmail.com>
…amesfoster#49) * Treat value types containing reference types as reference types Co-authored-by: James Foster <james.mdb@gmail.com>
Include Readme.md in Nuget package
Add link to Nuget package
Pure methods do not have side effects. Changing the IgnoredProperty list of ComparisonBuilder inside CompareSyntax is an side effect since it is changing non-local resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure methods do not have side effects. Changing the IgnoredProperty list of ComparisonBuilder inside
CompareSyntax is an side effect since it is changing non-local resource.
Thank you for the great tool :-)