Merge pull request nteract#4550 from justvaldes/change-plotly-dependency

Depend on official plotly bundle
jameskoch · Sep 4, 2019 · 8b57131 · 8b57131
2 parents e0f505a + fa1321c
commit 8b57131
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/...sform-plotly/__mocks__/@nteract/plotly.ts → ...nsform-plotly/__mocks__/plotly/js-dist.ts b/...sform-plotly/__mocks__/@nteract/plotly.ts → ...nsform-plotly/__mocks__/plotly/js-dist.ts
diff --git a/packages/transform-plotly/__tests__/plotly.test.tsx b/packages/transform-plotly/__tests__/plotly.test.tsx
@@ -4,7 +4,8 @@ import React from "react";
 
 import PlotlyTransform from "../src";
 
-const plotly = require("@nteract/plotly");
+jest.mock("plotly.js-dist")
+const plotly = require("plotly.js-dist");
 
 function deepFreeze(obj) {
   // Retrieve the property names defined on obj

diff --git a/packages/transform-plotly/package.json b/packages/transform-plotly/package.json
@@ -12,7 +12,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@nteract/plotly": "^1.0.0",
+    "plotly.js-dist": "^1.48.3",
     "lodash": "^4.17.4"
   },
   "peerDependencies": {

diff --git a/packages/transform-plotly/src/index.tsx b/packages/transform-plotly/src/index.tsx
@@ -60,7 +60,7 @@ export class PlotlyTransform extends React.Component<Props> {
   componentDidMount(): void {
     // Handle case of either string to be `JSON.parse`d or pure object
     const figure = this.getFigure();
-    this.Plotly = require("@nteract/plotly");
+    this.Plotly = require("plotly.js-dist");
     this.Plotly.newPlot(this.plotDiv, figure.data, figure.layout);
   }
 

diff --git a/scripts/test-shim.ts b/scripts/test-shim.ts
@@ -26,6 +26,7 @@ const createContextualFragment = html => {
 Range.prototype.createContextualFragment = html =>
   createContextualFragment(html);
 
+global.window.URL.createObjectURL = function() {};
 global.window.focus = () => {};
 
 // HACK: Polyfill that allows codemirror to render in a JSDOM env.