-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3233 UI: Common method to delete server and custom directory entries #3260
base: main
Are you sure you want to change the base?
Conversation
I added a horizontal box layout which include the box and the delete button. I wrote a fonction to implement the delete button. It works well when we change the focus with the mouse to add a new directory but I can't make the enter key work : it delete the input and nothing happend. I tried to add the QLineEdit::returnPressed signal but it changed nothing. I struggle to understand the former use of the QComboBox::activated signal since I commented it and nothing seems to have changed. TODO : Allowing to add directory via enter key. Improve spacers in the ui.
Thanks for opening this PR. It's a draft/WIP so it needs discussion. @pljones Should be most familiar with this. |
Could you please also post your questions here? Best right in the code tab close to where the question arises. |
Hello, It works for the main part, I mostly followed this commit. However, I have some issues :
I have still things to improve such as the interface (boxes are not equally spaced), but I would like your opinion to continue this way ! Thanks for your time ! |
Thanks Adam! I started to look at your commit and questions earlier today, but got diverted onto other things. I will have a look soon, hopefully tomorrow! |
I followed the suggestions made py @pljones and I changed a size hint of a spacer in the UI to make sure that everything is evenly spaced. TODO : Allowing adding directory via enter key
I used flags to allow the use of only one function for the delete button and the list itself, I deleted a ":" in the label (other labels didn't use ":") and I added a tabstop for the button
I added return in case the data isn't valid. I also added a ":" to avoid translations problems.
Looks good to me, now. I've kicked off the build. Thanks for all the time you've spent on this! :) |
Thank you for your patience and your advices :) |
Just tried the Windows version from the build artifacts and it looks okay to me. |
This needs some squashing and rebasing, I believe. I'll look into it once I have time. |
I added a horizontal box layout which include the box and the delete button. I wrote a fonction to implement the delete button.
It works well when we change the focus with the mouse to add a new directory but I can't make the enter key work : it delete the input and nothing happend. I tried to add the QLineEdit::returnPressed signal but it changed nothing. I struggle to understand the former use of the QComboBox::activated signal since I commented it and nothing seems to have changed.
TODO :
Allowing to add directory via enter key.
Improve spacers in the ui.
Short description of changes
CHANGELOG: UI: Add "Delete Entry" button to Advanced Settings, Custom Directories
Context: Fixes an issue?
#3233
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist