Refactor to support importing from go #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandelgado
reviewed
May 1, 2021
There was a problem hiding this comment.
Thanks @jinhong- , I think this improves the code and adds new use-cases. Please look at my comment, I think we should rename the AbsolutePathResolver
| blocks, err := parseCoverage(in, pathResolverFunc) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return writeLcov(blocks, out) | ||
| } | ||
|
|
||
| func AbsolutePathResolver(name string) string { | ||
| return name | ||
| func AbsolutePathResolver(name string) (string, error) { |
There was a problem hiding this comment.
I think the name is a little bit misleading and should have been named something like IdentityPathResolver since the function does not actually change or make a path absolute (as can be seen in the test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I did some refactors to allow me to import gcov2lcov to use in my code directly. Not sure if you are keen to merge this back into your repo but here it is :)