New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for symfony 5.1 #334
Conversation
Thanks for your contribution ! |
More exactly framework-bundle 5.1.0 |
Ofc, and what is the problem with framework bundle 5.1? |
Sorry on my phone, there is issue with serializer & 5.1.0. See symfony/symfony#37058 for related fix |
Np, I added conflict with that bundle version 5.1.0. |
@@ -20,7 +20,7 @@ | |||
"require-dev": { | |||
"doctrine/annotations": "~1.0", | |||
"phpdocumentor/reflection-docblock": "^3.0 || ^4.0", | |||
"symfony/serializer": "^4.2 || 5.0.*" | |||
"symfony/serializer": "^4.2 || ^5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This composer file should also conflict framework-bundle 5.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, I'll add it to every package, that requires sf serializer
I'll make a new tag later, not at home atm but you will have it today |
Also, could you target 6.0.x branch please ? |
I had to create another PR for that. Feel free to close this one or merge, as you wish. Here is the 6.0.x one: #335 |
Closing this PR since #335 as been merged, thanks again for your contribution ! |
Current version 6.0.1 does not support symfony 5.1.
This commit should fix it