Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for symfony 5.1 #334

Closed
wants to merge 3 commits into from
Closed

Fix support for symfony 5.1 #334

wants to merge 3 commits into from

Conversation

FilipBenco
Copy link
Contributor

Current version 6.0.1 does not support symfony 5.1.

This commit should fix it

@Korbeil
Copy link
Member

Korbeil commented Jun 13, 2020

Thanks for your contribution !
Could you please add a conflict with 5.1.0 ?

@Korbeil
Copy link
Member

Korbeil commented Jun 13, 2020

More exactly framework-bundle 5.1.0

@FilipBenco
Copy link
Contributor Author

Ofc, and what is the problem with framework bundle 5.1?

@Korbeil
Copy link
Member

Korbeil commented Jun 13, 2020

Ofc, and what is the problem with framework bundle 5.1?

Sorry on my phone, there is issue with serializer & 5.1.0. See symfony/symfony#37058 for related fix

@FilipBenco
Copy link
Contributor Author

Np, I added conflict with that bundle version 5.1.0.
(Could you then please also bump the version of jane, so we can use it in our sf 5.1 projects? :) )

@@ -20,7 +20,7 @@
"require-dev": {
"doctrine/annotations": "~1.0",
"phpdocumentor/reflection-docblock": "^3.0 || ^4.0",
"symfony/serializer": "^4.2 || 5.0.*"
"symfony/serializer": "^4.2 || ^5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This composer file should also conflict framework-bundle 5.1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I'll add it to every package, that requires sf serializer

@Korbeil
Copy link
Member

Korbeil commented Jun 13, 2020

Np, I added conflict with that bundle version 5.1.0.
(Could you then please also bump the version of jane, so we can use it in our sf 5.1 projects? :) )

I'll make a new tag later, not at home atm but you will have it today

@Korbeil
Copy link
Member

Korbeil commented Jun 13, 2020

Also, could you target 6.0.x branch please ?

@FilipBenco FilipBenco changed the base branch from master to 6.0.x June 13, 2020 07:58
@FilipBenco FilipBenco changed the base branch from 6.0.x to master June 13, 2020 07:58
@FilipBenco
Copy link
Contributor Author

I had to create another PR for that. Feel free to close this one or merge, as you wish. Here is the 6.0.x one: #335

@Korbeil
Copy link
Member

Korbeil commented Jun 13, 2020

Closing this PR since #335 as been merged, thanks again for your contribution !

@Korbeil Korbeil closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants