Add null safe operator in case $schema is null #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ``` PHP Fatal error: Uncaught Error: Call to a member function getType() on null in /...vendor/jane-php/open-api-3/Generator/RequestBodyContent/AbstractBodyContentGenerator.php:35 ``` I had a case when open api specification was valid (according to swagger) but requestBody>content element didn't had any schema and it caused issues while generating PHP code
Korbeil
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks @vaidas-lungis for your contribution ! It looks good to me :)
Could you add a test to validate this issue and a note in the CHANGELOG file about your changes ?
Thanks again 🙏
|
I will try to do that ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
I had a case when open api specification is valid (according to swagger.io tool) but few endpoints requestBody>content elements didn't had any schema property (
application/xml) and it causes issues while generating PHP code (./vendor/bin/jane-openapi generate).