Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time weighted retrieval #2908

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

thunhuanh
Copy link

Describe Your Changes

  • Added Time-weighted Retrieval functionality

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@thunhuanh
Copy link
Author

Hi @louis-jan, can you help me review this?

@Van-QA Van-QA requested a review from louis-jan May 15, 2024 14:47
@louis-jan
Copy link
Contributor

Please help resolve conflict. We will proceed then.

@thunhuanh
Copy link
Author

Please help resolve conflict. We will proceed then.

I have resolveed the conflict @louis-jan, Can you help me review it?
Thank you for your patience.

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan
Copy link
Contributor

@Van-QA @namchuai Please help proceed with this PR. Looks great.

@Van-QA
Copy link
Contributor

Van-QA commented Jun 3, 2024

hi @thunhuanh, Linter faile‌d, can ‌you h‌elp us double chec‌k? thank you 🙏
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add support for Time-weighted vector store retriever
4 participants