test: Set typescript to strict mode (noImplicityAny:false)

jantimon · Jun 3, 2018 · 1063b04 · 1063b04
1 parent b6dec4b
commit 1063b04
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/index.js b/index.js
@@ -38,7 +38,7 @@ class HtmlWebpackPlugin {
      */
     this.options = Object.assign({
       template: path.join(__dirname, 'default_index.ejs'),
-      templateContent: undefined,
+      templateContent: false,
       templateParameters: templateParametersGenerator,
       filename: 'index.html',
       hash: false,
@@ -155,7 +155,7 @@ class HtmlWebpackPlugin {
           .then(() => compilationPromise)
           .then(compiledTemplate => {
           // Allow to use a custom function / string instead
-            if (self.options.templateContent !== undefined) {
+            if (self.options.templateContent !== false) {
               return self.options.templateContent;
             }
             // Once everything is compiled evaluate the html factory
@@ -402,7 +402,7 @@ class HtmlWebpackPlugin {
       publicPath: string,
       js: Array<{entryName: string, path: string}>,
       css: Array<{entryName: string, path: string}>,
-      manifest: string,
+      manifest?: string,
       favicon?: string
     }}
    */
@@ -430,7 +430,7 @@ class HtmlWebpackPlugin {
         publicPath: string,
         js: Array<{entryName: string, path: string}>,
         css: Array<{entryName: string, path: string}>,
-        manifest: string,
+        manifest?: string,
         favicon?: string
       }}
      */
@@ -448,7 +448,7 @@ class HtmlWebpackPlugin {
     };
 
     // Append a hash for cache busting
-    if (this.options.hash) {
+    if (this.options.hash && assets.manifest) {
       assets.manifest = this.appendHash(assets.manifest, compilationHash);
     }
 

diff --git a/lib/hooks.js b/lib/hooks.js
@@ -33,7 +33,6 @@ const AsyncSeriesWaterfallHook = require('tapable').AsyncSeriesWaterfallHook;
         publicPath: string,
         js: Array<{entryName: string, path: string}>,
         css: Array<{entryName: string, path: string}>,
-        manifest: string,
       },
       outputName: string,
       plugin: HtmlWebpackPlugin
@@ -45,7 +44,6 @@ const AsyncSeriesWaterfallHook = require('tapable').AsyncSeriesWaterfallHook;
         publicPath: string,
         js: Array<{entryName: string, path: string}>,
         css: Array<{entryName: string, path: string}>,
-        manifest: string,
       },
       outputName: string,
       plugin: HtmlWebpackPlugin,
@@ -57,7 +55,6 @@ const AsyncSeriesWaterfallHook = require('tapable').AsyncSeriesWaterfallHook;
         publicPath: string,
         js: Array<{entryName: string, path: string}>,
         css: Array<{entryName: string, path: string}>,
-        manifest: string,
       },
       outputName: string,
       plugin: HtmlWebpackPlugin,

diff --git a/tsconfig.json b/tsconfig.json
@@ -7,8 +7,8 @@
     "lib": ["es2017"],
 
     /* Strict Type-Checking Options */
-    "strict": false,                          /* Enable all strict type-checking options. */
-    // "noImplicitAny": true,                 /* Raise error on expressions and declarations with an implied 'any' type. */
+    "strict": true,                           /* Enable all strict type-checking options. */
+    "noImplicitAny": false,                   /* Raise error on expressions and declarations with an implied 'any' type. */
     // "strictNullChecks": true,              /* Enable strict null checks. */
     // "strictFunctionTypes": true,           /* Enable strict checking of function types. */
     // "strictPropertyInitialization": true,  /* Enable strict checking of property initialization in classes. */

diff --git a/typings.d.ts b/typings.d.ts
@@ -8,14 +8,17 @@ interface HtmlWebpackPluginOptions {
      */
     title: string,
     /**
-     * `webpack` require path to the template.
+     * The `webpack` require path to the template.
      * @see https://github.com/jantimon/html-webpack-plugin/blob/master/docs/template-option.md
      */
     template: string,
     /**
-     *
+     * Allow to use a html string instead of reading from a file
      */
-    templateContent: string | (() => string),
+    templateContent:
+      false // Use the template option instead to load a file
+      | string
+      | Promise<string>,
     /**
      * Allows to overwrite the parameters used in the template
      */