Skip to content

Commit b46bf67

Browse files
jantimonjantimon
committedJun 3, 2018
feat: Remove type="text/javascript" from injected script tags
See https://www.w3.org/TR/html5/scripting-1.html#attr-script-type “The default, which is used if the attribute is absent, is "text/javascript"” BREAKING CHANGE: The mimetype information "text/javascript" is removed from all generated script tags
·
v5.6.3v4.0.0
1 parent cc3bf49 commit b46bf67

File tree

21 files changed

+61
-62
lines changed

21 files changed

+61
-62
lines changed
 

‎examples/appcache/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!doctype html><html lang="en" manifest="manifest.appcache"><head><meta charset="utf-8"><title>Example template</title><meta name="viewport" content="width=device-width,initial-scale=1"><link href="styles.css" rel="stylesheet"></head><body><img src="0714810ae3fb211173e2964249507195.png"><script type="text/javascript" src="bundle.js"></script></body></html>
1+
<!doctype html><html lang="en" manifest="manifest.appcache"><head><meta charset="utf-8"><title>Example template</title><meta name="viewport" content="width=device-width,initial-scale=1"><link href="styles.css" rel="stylesheet"></head><body><img src="0714810ae3fb211173e2964249507195.png"><script src="bundle.js"></script></body></html>

‎examples/custom-template/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@
88
<body>
99
<h2>Partial</h2>
1010
<img src="0714810ae3fb211173e2964249507195.png">
11-
<script type="text/javascript" src="bundle.js"></script></body>
11+
<script src="bundle.js"></script></body>
1212
</html>

‎examples/default/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
<title>Webpack App</title>
66
</head>
77
<body>
8-
<script type="text/javascript" src="bundle.js"></script></body>
8+
<script src="bundle.js"></script></body>
99
</html>

‎examples/favicon/dist/webpack-4/favicon.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
<title>HtmlWebpackPlugin example</title>
66
<link rel="shortcut icon" href="favicon.ico"><link href="styles.css" rel="stylesheet"></head>
77
<body>
8-
<script type="text/javascript" src="bundle.js"></script></body>
8+
<script src="bundle.js"></script></body>
99
</html>

‎examples/html-loader/dist/webpack-4/about.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
<link rel="shortcut icon" href="favicon.ico"><link href="styles.css" rel="stylesheet"></head>
88
<body>
99
<img src="0714810ae3fb211173e2964249507195.png">
10-
<script type="text/javascript" src="bundle.js"></script></body>
10+
<script src="bundle.js"></script></body>
1111
</html>

‎examples/html-loader/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
<link rel="shortcut icon" href="favicon.ico"><link href="styles.css" rel="stylesheet"></head>
88
<body>
99
<img src="0714810ae3fb211173e2964249507195.png">
10-
<script type="text/javascript" src="bundle.js"></script></body>
10+
<script src="bundle.js"></script></body>
1111
</html>

‎examples/inline/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<!DOCTYPE html><html><head><meta http-equiv="Content-type" content="text/html; charset=utf-8"><title>Jade demo</title></head><body><style>body {
22
background: snow;
3-
}</style><script type="text/javascript">/******/ (function(modules) { // webpackBootstrap
3+
}</style><script>/******/ (function(modules) { // webpackBootstrap
44
/******/ // The module cache
55
/******/ var installedModules = {};
66
/******/

‎examples/inline/template.jade

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ html
77
each cssFile in htmlWebpackPlugin.files.css
88
style !{compilation.assets[cssFile.substr(htmlWebpackPlugin.files.publicPath.length)].source()}
99
each jsFile in htmlWebpackPlugin.files.js
10-
script(type="text/javascript") !{compilation.assets[jsFile.substr(htmlWebpackPlugin.files.publicPath.length)].source()}
10+
script !{compilation.assets[jsFile.substr(htmlWebpackPlugin.files.publicPath.length)].source()}

‎examples/jade-loader/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!DOCTYPE html><html><head><title>Jade demo</title><link rel="shortcut icon" href="favicon.ico"><link href="styles.css" rel="stylesheet"></head><body><div id="main"><!-- this partial is used for frontend and backend--><div class="time"> <b>Current time</b><p>1999-01-01T05:00:00.000Z</p></div><img src="0714810ae3fb211173e2964249507195.png"></div><script type="text/javascript" src="bundle.js"></script></body></html>
1+
<!DOCTYPE html><html><head><title>Jade demo</title><link rel="shortcut icon" href="favicon.ico"><link href="styles.css" rel="stylesheet"></head><body><div id="main"><!-- this partial is used for frontend and backend--><div class="time"> <b>Current time</b><p>1999-01-01T05:00:00.000Z</p></div><img src="0714810ae3fb211173e2964249507195.png"></div><script src="bundle.js"></script></body></html>

‎examples/javascript-advanced/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
<html><head><title>Webpack App</title><link href="styles.css" rel="stylesheet"></head><body>Hello World from backend - <h2>Partial</h2>
2-
<img src="0714810ae3fb211173e2964249507195.png"><script type="text/javascript" src="bundle.js"></script></body></html>
2+
<img src="0714810ae3fb211173e2964249507195.png"><script src="bundle.js"></script></body></html>

‎examples/javascript/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
<head><link href="styles.css" rel="stylesheet"></head>Hello World from backend2018-02-14T04:00:28.077Z<h2>Partial</h2>
2-
<img src="0714810ae3fb211173e2964249507195.png"><script type="text/javascript" src="bundle.js"></script>
2+
<img src="0714810ae3fb211173e2964249507195.png"><script src="bundle.js"></script>

‎examples/sort-manually/dist/webpack-4/first-file.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
<link href="styles.css" rel="stylesheet"></head>
88
<body>
99
<img src="0714810ae3fb211173e2964249507195.png">
10-
<script type="text/javascript" src="a.js"></script><script type="text/javascript" src="b.js"></script><script type="text/javascript" src="c.js"></script></body>
10+
<script src="a.js"></script><script src="b.js"></script><script src="c.js"></script></body>
1111
</html>

‎examples/sort-manually/dist/webpack-4/second-file.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
<link href="styles.css" rel="stylesheet"></head>
88
<body>
99
<img src="0714810ae3fb211173e2964249507195.png">
10-
<script type="text/javascript" src="a.js"></script><script type="text/javascript" src="b.js"></script><script type="text/javascript" src="d.js"></script></body>
10+
<script src="a.js"></script><script src="b.js"></script><script src="d.js"></script></body>
1111
</html>

‎examples/template-parameters/dist/webpack-4/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
<title>bar</title>
66
</head>
77
<body>
8-
<script type="text/javascript" src="bundle.js"></script></body>
8+
<script src="bundle.js"></script></body>
99
</html>

‎index.js

-1
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,6 @@ class HtmlWebpackPlugin {
556556
tagName: 'script',
557557
voidTag: false,
558558
attributes: {
559-
type: 'text/javascript',
560559
src: scriptPath
561560
}
562561
}));

‎spec/BasicSpec.js

+42-42
Large diffs are not rendered by default.

‎spec/fixtures/invalid.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
</head>
77
<body>
88
<p>Some unique text</p>
9-
<script type="text/javascript" src="<%=foo.bar%>"></script>
9+
<script src="<%=foo.bar%>"></script>
1010
</body>
1111
</html>

‎spec/fixtures/legacy.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
</head>
77
<body>
88
<p>Some unique text</p>
9-
<script type="text/javascript" src="{%=o.htmlWebpackPlugin.assets.app%}"></script>
9+
<script src="{%=o.htmlWebpackPlugin.assets.app%}"></script>
1010
</body>
1111
</html>

‎spec/fixtures/template.jade

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ html
66
body
77
p Some unique text
88
each jsFile in htmlWebpackPlugin.files.js
9-
script(type="text/javascript" src!=jsFile)
9+
script(src!=jsFile)

‎spec/fixtures/test.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
</head>
77
<body>
88
<p>Some unique text</p>
9-
<script type="text/javascript" src="<%=htmlWebpackPlugin.files.chunks.app.entry%>"></script>
9+
<script src="<%=htmlWebpackPlugin.files.chunks.app.entry%>"></script>
1010
</body>
1111
</html>

‎spec/fixtures/webpackconfig.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
</head>
77
<body>
88
<p>Public path is <%= webpackConfig.output.publicPath %></p>
9-
<script type="text/javascript" src="<%= htmlWebpackPlugin.files.chunks.app.entry %>?<%= htmlWebpackPlugin.files.chunks.app.hash %>"></script>
9+
<script src="<%= htmlWebpackPlugin.files.chunks.app.entry %>?<%= htmlWebpackPlugin.files.chunks.app.hash %>"></script>
1010
</body>
1111
</html>

0 commit comments

Comments
 (0)
Please sign in to comment.