html-webpack-plugin 4.x - Switching to Webpack 4 api #953

jantimon · 2018-05-21T12:47:59Z

Bug Fixes

chunksorter: Don't sort chunks by default (22fb03f)
loader: switch to loaderUtils.getOptions (a0a0f0d)
tests: Upgrade webpack-recompilation-simulator (dfe1d10)
Add dependencies from the child compilation to the main compilation (27c3e72)
Ignore foreign child compilers (1422664)
Improve perfomance for appcache files (b94e043)
Prevent chunks from beeing added multiple times (d65b37d)
Remove compilation.getStats() call for performance reasons (7005a55)
Update lodash to 4.17.10 (cc3bf49)

Code Refactoring

Change the structure of the internal assets object (37db086)
Changed hook names and arguments - the hook order is 'beforeAssetTagGeneration', 'alterAssetTags', 'alterAssetTagGroups', 'afterTemplateExecution', 'beforeEmit', 'afterEmit' (14b4456)
Drop support for Webpack 1-3 to use Webpack 4 apis (47efdea)

Features

Add default viewport meta tag for default template (302e39e), closes #897 #978
hooks: Add a helper for easier hook access (b6dec4b)
Add support for the [contenthash] placeholder inside htm file names (ae8233a)
Export major version of this plugin (6ae6f48)
Remove selfClosingTag (5d3d8e4)
Remove type="text/javascript" from injected script tags (b46bf67)
Replace jade with pug in examples (d7ec407)
Simplify element and charset attribute (55313be)
support ES6 template string in default loader (d6b65dd), closes #950
compiler: Add file dependencies (bbc07a3)
compiler: Use a single compiler for multiple plugin instances (f29ae88)
Switch from jasmine to jest (ae1f435)
Use jsdoc for static typing (a6b8d2d)
Use webpack 4 entries api to extract asset information (342867e)
compiler: Use timestamps to verify cache validity (0ebcd17)
hooks: Provide static getHook method for access to all html-webpack-plugin hooks (#995) (82b34a1)
html-tags: Add a helper to create html-tags (ee6a165)

BREAKING CHANGES

Renamed beforeHtmlGeneration hook to beforeAssetTagGeneration
loader: switch to loaderUtils getOptions
Renamed afterHtmlProcessing hook to beforeEmit
The default template has now a predefined viewport meta tag
hooks: The html-webpack-plugin doesn't add its hooks to the compilation object anymore
Pass the entry point names to the custom sort function instead of chunk objects. Removed the alterhtmlWebpackPluginAlterChunks hook. Changed the structure of the assets argument for all hooks.
The assets object which is used for the template parameters and inside hooks was changed. The chunks property was removed and the js and css property was converted from a string into an object { entryName: string, path: string}
Renamed beforeHtmlProcessing hook to alterAssetTags
The mimetype information "text/javascript" is removed from all generated script
tags
Remove selfClosingTag attribute
Template strings inside templates are now disabled by default
Dropped support for Webpack 1 - 3
Template variable webpack was removed
chunksorter: Chunks aren't sorted anymore by default
The default meta utf-8 declaration was changed to

New Event names

Performance improvements

Performance findings by different users for v4:

mohsen1

Great work! enabling the strict mode is not far

typings.d.ts

mohsen1 · 2018-05-21T17:22:07Z

lib/html-tags.js

+ */
+
+/**
+ * @type {string[]} - All html tag elements which must not contain innerHTML


Let typescript infer types if it can

mohsen1 · 2018-05-21T17:22:47Z

lib/html-tags.js

+
+/**
+ * Turn a tag definition into a html string
+ * @param tagDefinition {HtmlTagObject}


order is wrong. types come first

mohsen1 · 2018-05-21T17:23:32Z

lib/html-tags.js

+/// <reference path="../typings.d.ts" />
+/* eslint-enable */
+/*
+ * @file


To use JSDoc directives use JSDoc comment sections that start with /**

jantimon · 2018-05-22T12:33:54Z

Thanks for your fast and detailed feedback!
I managed to turn on typescripts strict mode (except noImplicitAny because of external dependencies like webpack)

jantimon · 2018-05-30T15:03:48Z

Released as alpha: https://www.npmjs.com/package/html-webpack-plugin/v/4.0.0-alpha

npm i html-webpack-plugin@next

BREAKING CHANGE: switch to loaderUtils getOptions

BREAKING CHANGE: Chunks aren't sorted anymore by default

BREAKING CHANGE: Template variable webpack was removed

BREAKING CHANGE: Dropped support for Webpack 1 - 3

Only transpile EJS style `<%= name %>`, Close #950 BREAKING CHANGE: Template strings inside templates are now disabled by default

BREAKING CHANGE: Remove selfClosingTag attribute

See https://www.w3.org/TR/html5/scripting-1.html#attr-script-type “The default, which is used if the attribute is absent, is "text/javascript"” BREAKING CHANGE: The mimetype information "text/javascript" is removed from all generated script tags

See https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Obsolete_things_to_avoid BREAKING CHANGE: The default meta utf-8 declaration was changed to <meta charset="utf-8"/>

jantimon · 2018-09-27T13:56:25Z

Released as 4.0.0-beta.1

edmorley · 2018-09-27T14:24:55Z

Hi! Thank you for preparing a new release. However it doesn't appear to be published/public?

$ yarn info html-webpack-plugin versions | grep '4.0.0'
  '4.0.0-alpha',
  '4.0.0-alpha.1',
  '4.0.0-alpha.2' ]

edmorley · 2018-09-27T18:28:58Z

Is available now - thank you :-)

BREAKING: `contenthash` in now `templatehash`. Since webpack 4.3 `contenthash` is used by webpack. to avoid conflicts, it is renamed to `templatehash`

Update JSDoc

Fixes: #1033

- types packages should not be installed for plugin users - adjusted bundles to current webpack@4 behavior

jantimon · 2018-10-15T05:49:11Z

Merged and released as html-webpack-plugin@4.0.0-beta.2.

This version is also the release candidate.
I am planing to release it at the end of October.

Saravanan90 · 2018-10-31T10:54:34Z

Waiting for 4.0.0 release @jantimon

jantimon · 2018-10-31T12:44:08Z

Hey @Saravanan90 so far feedback is quite good.

I would love to solve #1089 #1091 and #1072 before we release it as stable 4.x

Saravanan90 · 2018-11-20T07:02:11Z

Eagerly awaiting for 4.x stable release ❤️ Any ETA? 👀 @jantimon

jantimon requested a review from mastilver May 21, 2018 12:50

jantimon self-assigned this May 21, 2018

mohsen1 reviewed May 21, 2018

View reviewed changes

jantimon force-pushed the webpack-4 branch 2 times, most recently from c1e57b5 to 1eb2575 Compare May 22, 2018 12:16

jantimon mentioned this pull request May 25, 2018

Reduce stats requested at emit and optionally remove from template #825

Closed

This was referenced Jun 1, 2018

Options.cache does not prevent unchanged HTML pages from being rebuilt in watch mode #962

Closed

Timestamp based check for changes to HTML template #965

Closed

jantimon and others added 13 commits June 3, 2018 13:27

fix(loader): switch to loaderUtils.getOptions

a0a0f0d

BREAKING CHANGE: switch to loaderUtils getOptions

fix(chunksorter): Don't sort chunks by default

22fb03f

BREAKING CHANGE: Chunks aren't sorted anymore by default

fix: Remove compilation.getStats() call for performance reasons

7005a55

BREAKING CHANGE: Template variable webpack was removed

refactor: Drop support for Webpack 1-3 to use Webpack 4 apis

47efdea

BREAKING CHANGE: Dropped support for Webpack 1 - 3

fix: Improve perfomance for appcache files

b94e043

feat: support ES6 template string in default loader

d6b65dd

Only transpile EJS style `<%= name %>`, Close #950 BREAKING CHANGE: Template strings inside templates are now disabled by default

feat(html-tags): Add a helper to create html-tags

ee6a165

feat: Use jsdoc for static typing

a6b8d2d

feat: Export major version of this plugin

6ae6f48

feat: Remove selfClosingTag

5d3d8e4

BREAKING CHANGE: Remove selfClosingTag attribute

fix: Update lodash to 4.17.10

cc3bf49

feat: Simplify <meta> element and charset attribute

55313be

See https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Obsolete_things_to_avoid BREAKING CHANGE: The default meta utf-8 declaration was changed to <meta charset="utf-8"/>

docs: Restructure readme

bdcfe32

This was referenced Sep 28, 2018

Support html-webpack-plugin v4 GoogleChromeLabs/preload-webpack-plugin#79

Open

Last call for Create React App v2 facebook/create-react-app#5103

Closed

jantimon and others added 10 commits October 1, 2018 08:17

docs: Add docs for the meta tag option

6dda46e

docs(README): add csp-html-webpack-plugin

62e638c

perf: migrate from extract-text plugin to mini-css plugin

79a0448

fix: rename contenthash to templatehash

4c11c5d

BREAKING: `contenthash` in now `templatehash`. Since webpack 4.3 `contenthash` is used by webpack. to avoid conflicts, it is renamed to `templatehash`

revert: restore original filenames in examples

f4bccb7

feat: Add publicPath support relative path

dbbdd81

Update index.js

8e14a0b

Update JSDoc

perf: reject promises with errors

119e817

fix: allow contenthash along with templatehash

049d4d3

Fixes: #1033

chore: fix typos and remove unnecessary regexp test

24e4f10

This was referenced Oct 7, 2018

compatible with html-webpack-plugin v4 hooks GoogleChromeLabs/preload-webpack-plugin#80

Closed

compatible with html-webpack-plugin v4 hooks GoogleChromeLabs/preload-webpack-plugin#81

Closed

sibiraj-s and others added 2 commits October 8, 2018 14:26

chore: bump dependencies

3934cff

chore: @types/tapable to devDeps (#1076)

7fb656a

- types packages should not be installed for plugin users - adjusted bundles to current webpack@4 behavior

jantimon merged commit 7fb656a into master Oct 15, 2018

sibiraj-s mentioned this pull request Oct 15, 2018

Cannot read property 'tapAsync' of undefined when using with HTML Webpack Plugin 4.0.0-alpha.2 slackhq/csp-html-webpack-plugin#20

Closed

9 tasks

Saravanan90 mentioned this pull request Oct 16, 2018

[Feature] Support html-webpack-plugin 4.x slackhq/csp-html-webpack-plugin#16

Closed

4 tasks

jeffposnick mentioned this pull request Oct 25, 2018

[v4-beta.2] Alternative to htmlPluginData.assets.chunks? #1092

Closed

lock bot locked as resolved and limited conversation to collaborators Dec 20, 2018

jantimon deleted the webpack-4 branch January 2, 2020 11:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

html-webpack-plugin 4.x - Switching to Webpack 4 api #953

html-webpack-plugin 4.x - Switching to Webpack 4 api #953

jantimon commented May 21, 2018 •

edited

mohsen1 left a comment

mohsen1 May 21, 2018

mohsen1 May 21, 2018

mohsen1 May 21, 2018

jantimon commented May 22, 2018

jantimon commented May 30, 2018

jantimon commented Sep 27, 2018

edmorley commented Sep 27, 2018

edmorley commented Sep 27, 2018

jantimon commented Oct 15, 2018

Saravanan90 commented Oct 31, 2018

jantimon commented Oct 31, 2018

Saravanan90 commented Nov 20, 2018

html-webpack-plugin 4.x - Switching to Webpack 4 api #953

html-webpack-plugin 4.x - Switching to Webpack 4 api #953

Conversation

jantimon commented May 21, 2018 • edited

Bug Fixes

Code Refactoring

Features

BREAKING CHANGES

New Event names

Performance improvements

mohsen1 left a comment

Choose a reason for hiding this comment

mohsen1 May 21, 2018

Choose a reason for hiding this comment

mohsen1 May 21, 2018

Choose a reason for hiding this comment

mohsen1 May 21, 2018

Choose a reason for hiding this comment

jantimon commented May 22, 2018

jantimon commented May 30, 2018

jantimon commented Sep 27, 2018

edmorley commented Sep 27, 2018

edmorley commented Sep 27, 2018

jantimon commented Oct 15, 2018

Saravanan90 commented Oct 31, 2018

jantimon commented Oct 31, 2018

Saravanan90 commented Nov 20, 2018

jantimon commented May 21, 2018 •

edited