Rename contenthash to hashByContent to resolve internal webpack conflict

[pegiadise]

This occurs with webpack >= 4.3 because they internally added a [contentHash] variable. The simplest way around it is to rename the key to something else which is what I did here. I needed a quick fix for it, but I also stand by the choice of choosing a different key there because:

1. more declarative as to what it is doing
2. treating webpack internal variables as a black box

Closes #1033

[jantimon]

Wouldn't it be better to keep [contenthash] and tell webpack to ignore it instead of coming up with our own new syntax?

[pegiadise]

Maybe you are right. I took a look at mini-css-extract-plugin way of doing it, but you might be more familiar with tapping into compilation hooks. Also it would probably require bumping webpack to a higher version and I don't know if there are any restrictions right now holding you there.

[jantimon]

Would it work to replace [contenthash] to [html-webpack-plugin-contenthash] during startup and change

html-webpack-plugin/index.js

Line 268 in fb448dd

const finalOutputName = childCompilationOutputName.replace(/\[(?:(\w+):)?contenthash(?::([a-z]+\d*))?(?::(\d+))?\]/ig, (_, hashType, digestType, maxLength) => {

to html-webpack-plugin-contenthash?

[sibiraj-s]

how about templatehash? Since the plugin generates hashes from a template

[pegiadise]

@sibiraj-s [templatehash] sounds like a good alternative but I think the maintainer wants to keep the [contenthash] in order to generally comply with webpack API. @jantimon I 'll give your proposal a try tonight and get back to you.

[sibiraj-s]

but I think the maintainer wants to keep the [contenthash] in order to generally comply with webpack API.

hi @pegiadise . You are correct. Can you check #1065 before you work on something? I tried to preserve both contenthash and templatehash

[jantimon]

Moved to #1065