New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create lazy loading lookup class to support pickling #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
reviewed
Oct 8, 2022
jaraco
reviewed
Oct 8, 2022
jaraco
reviewed
Oct 8, 2022
jaraco
reviewed
Oct 8, 2022
jaraco
reviewed
Oct 8, 2022
jaraco
reviewed
Oct 8, 2022
jaraco
reviewed
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #81 by creating a lazy-loading
FastLookup
object if the root is a string or apathlib.Path
object. By doing this, when either a string or apathlib.Path
is used as a root for azipp.Path
, the path object does not hold an open file handle, and thus can be pickled.zipp.Path
objects that are pickleable can then be passed around multiprocessing libraries without fear of running into the dreadedTypeError: cannot serialize '_io.BufferedReader' object
error.