Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dark mode alert style #137

Merged
merged 2 commits into from May 22, 2020
Merged

fix dark mode alert style #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d150aa
fix dark mode alert style
jaredks May 17, 2020
33a77d6
update CHANGES.rst
jaredks May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@ Changes
0.3.0.dev
---------

- Fix dark mode alert style #137
- Notifications: fixes, cleanup, and tests #131
- Fix slider for some older macOS versions (10.11 and before?)
- Keyboard interrupts now stop a running application
Expand Down
2 changes: 2 additions & 0 deletions rumps/rumps.py
View file
Open in desktop
Expand Up @@ -75,6 +75,7 @@ def alert(title=None, message='', ok=None, cancel=None, other=None, icon_path=No
cancel = 'Cancel' if cancel else None
alert = NSAlert.alertWithMessageText_defaultButton_alternateButton_otherButton_informativeTextWithFormat_(
title, ok, cancel, other, message)
alert.window().setAppearance_(AppKit.NSAppearance.currentAppearance())
alert.setAlertStyle_(0) # informational style
if icon_path is not None:
icon = _nsimage_from_file(icon_path)
Expand Down Expand Up @@ -846,6 +847,7 @@ def run(self):
:return: a :class:`rumps.rumps.Response` object that contains the text and the button clicked as an integer.
"""
_log(self)
self._alert.window().setAppearance_(AppKit.NSAppearance.currentAppearance())
clicked = self._alert.runModal() % 999
if clicked > 2 and self._cancel:
clicked -= 1
Expand Down