Skip to content

Commit

Permalink
- Responded to reviewer feedback to use the **callback** versions of …
Browse files Browse the repository at this point in the history
…`start()` and `stop()` with a generic error handler
  • Loading branch information
heath-freenome committed Oct 23, 2021
1 parent 9754732 commit 8c90455
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions packages/razzle/scripts/start.js
Expand Up @@ -168,6 +168,13 @@ function main() {
);
}

// Provide a reusable logger function
const errorLogger = (err) => {
if (err) {
logger.error(err);
}
};

if (!serverOnly) {
// Create a new instance of Webpack-dev-server for our client assets.
// This will actually run on a different port than the users app.
Expand All @@ -177,14 +184,10 @@ function main() {
);
if (devServerMajorVersion > 3) {
// listen was deprecated in v4 and causes issues when used, switch to its replacement
clientDevServer.start();
clientDevServer.startCallback(errorLogger);
} else {
// Start Webpack-dev-server
clientDevServer.listen(port, err => {
if (err) {
logger.error(err);
}
});
clientDevServer.listen(port, errorLogger);
}
}

Expand All @@ -193,9 +196,9 @@ function main() {
if (clientDevServer) {
if (devServerMajorVersion > 3) {
// close was deprecated in v4, switch to its replacement
clientDevServer.stop();
clientDevServer.stopCallback(errorLogger);
} else {
clientDevServer.close();
clientDevServer.close(errorLogger);
}
}
if (watching) {
Expand Down

0 comments on commit 8c90455

Please sign in to comment.