New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional follow-up fix for #1704 to remove remaining warnings #1736
Merged
fivethreeo
merged 8 commits into
jaredpalmer:master
from
heath-freenome:additional-update-to-fix-warnings
Oct 24, 2021
Merged
Additional follow-up fix for #1704 to remove remaining warnings #1736
fivethreeo
merged 8 commits into
jaredpalmer:master
from
heath-freenome:additional-update-to-fix-warnings
Oct 24, 2021
Commits on Oct 20, 2021
-
Additional follow-up fix for jaredpalmer#1704 to remove remaining war…
…nings - Added `devServerMajor.js` to `razzle-dev-utils` that refactors the detection of the `webpack-dev-server` version in a manner similar to `webpackMajor.js` - Updated `webpackHotDevClient.js` to use `devServerMajor.js` to pickup the properly cased `createSocketUrl` - Hopefully this approach won't break things like the change that was made previously that ended up getting reverted - Updated `createConfigAsync.js` to use `razzle-dev-utils/devServerMajor` for the `webpack-dev-server` version as well as: - Restored `hot: true` to the common `devServer` config and instead only explicitly adding the `HMR` to the plugins for v3 to avoid the following warning: ``` [webpack-dev-server] "hot: true" automatically applies HMR plugin, you don't have to add it manually to your webpack configuration. ``` - Updated `start.js` script to include `devServerMajor.js` so that v4 will `start/stop` the client dev server rather than `listen/close` used for v3 - Also added `port` into the copied `devServer` config to allow `start()` to work properly
Configuration menu - View commit details
-
Copy full SHA for 2a362ae - Browse repository at this point
Copy the full SHA 2a362aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for de1903e - Browse repository at this point
Copy the full SHA de1903eView commit details -
- Fixed the initialization of
createSocketUrl
variable to happen be……fore it is used
Configuration menu - View commit details
-
Copy full SHA for 2cd8075 - Browse repository at this point
Copy the full SHA 2cd8075View commit details -
Configuration menu - View commit details
-
Copy full SHA for e03de48 - Browse repository at this point
Copy the full SHA e03de48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 722186a - Browse repository at this point
Copy the full SHA 722186aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a859278 - Browse repository at this point
Copy the full SHA a859278View commit details
Commits on Oct 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9754732 - Browse repository at this point
Copy the full SHA 9754732View commit details
Commits on Oct 23, 2021
-
- Responded to reviewer feedback to use the **callback** versions of …
…`start()` and `stop()` with a generic error handler
Configuration menu - View commit details
-
Copy full SHA for 8c90455 - Browse repository at this point
Copy the full SHA 8c90455View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.