Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional follow-up fix for #1704 to remove remaining warnings #1736

Merged

Commits on Oct 20, 2021

  1. Additional follow-up fix for jaredpalmer#1704 to remove remaining war…

    …nings
    
    - Added `devServerMajor.js` to `razzle-dev-utils` that refactors the detection of the `webpack-dev-server` version in a manner similar to `webpackMajor.js`
    - Updated `webpackHotDevClient.js` to use `devServerMajor.js` to pickup the properly cased `createSocketUrl`
      - Hopefully this approach won't break things like the change that was made previously that ended up getting reverted
    - Updated `createConfigAsync.js` to use `razzle-dev-utils/devServerMajor` for the `webpack-dev-server` version as well as:
      - Restored `hot: true` to the common `devServer` config and instead only explicitly adding the `HMR` to the plugins for v3 to avoid the following warning:
    ```
    [webpack-dev-server] "hot: true" automatically applies HMR plugin, you don't have to add it manually to your webpack configuration.
    ```
    - Updated `start.js` script to include `devServerMajor.js` so that v4 will `start/stop` the client dev server rather than `listen/close` used for v3
      - Also added `port` into the copied `devServer` config to allow `start()` to work properly
    heath-freenome committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    2a362ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de1903e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2cd8075 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e03de48 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    722186a View commit details
    Browse the repository at this point in the history
  6. - Fix another comment

    heath-freenome committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    a859278 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Configuration menu
    Copy the full SHA
    9754732 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. - Responded to reviewer feedback to use the **callback** versions of …

    …`start()` and `stop()` with a generic error handler
    heath-freenome committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    8c90455 View commit details
    Browse the repository at this point in the history