Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onFailure example #416

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix onFailure example #416

merged 1 commit into from
Jan 6, 2020

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Jan 5, 2020 •
edited

Hey, thanks for tsdx and all of the latest changes! Spotted what seems to be a typo in one of the newer examples. Here's a quick PR to fix.

@jaredpalmer jaredpalmer merged commit 9e8ab92 into jaredpalmer:master Jan 6, 2020
@swyxio
Copy link
Collaborator

swyxio commented Jan 24, 2020

thanks for the great PR! @all-contributors please add @karlhorky for docs

@allcontributors allcontributors bot mentioned this pull request Jan 24, 2020
Merged
@allcontributors
Copy link
Contributor

@sw-yx

I've put up a pull request to add @karlhorky! 🎉

@karlhorky
Copy link
Contributor Author

Thanks @sw-yx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karlhorky @swyxio @jaredpalmer