Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automate releases #613

Closed
wants to merge 10 commits into from
Closed

chore: automate releases #613

wants to merge 10 commits into from

Conversation

guslen
Copy link

@guslen guslen commented Nov 17, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This automates the versioning fully and takes care of packaging dependencies correctly

@guslen guslen changed the title Feature/automate release Automate Releases Nov 17, 2023
@guslen
Copy link
Author

guslen commented Nov 17, 2023

@jaredwray this is probably duplicates #612 but maybe it also helps. Feel free to copy paste from here whatever you like.
The repo needs an NPM_TOKEN variable set up in the secrets section in order to work properly.

@QuentinLemCode
Copy link
Contributor

Hello
It seems more elaborate than my PR
However maybe you can divide in multiple PR

  • one for editing markdown file
  • one for adding rimraf
  • one for updating/adding github action workflows

It would be more easier to review and address potential issues or suggestions for improvement

Thanks ❤️

@guslen
Copy link
Author

guslen commented Nov 18, 2023

Hello It seems more elaborate than my PR However maybe you can divide in multiple PR

  • one for editing markdown file
  • one for adding rimraf
  • one for updating/adding github action workflows

It would be more easier to review and address potential issues or suggestions for improvement

Thanks ❤️

@QuentinLemCode
this pr takes care of the style issues #614

@guslen
Copy link
Author

guslen commented Nov 18, 2023

@QuentinLemCode this takes care of the change to replace yarn with npm in the scripts section
#615

@guslen guslen changed the title Automate Releases chore: automate releases Nov 18, 2023
@guslen
Copy link
Author

guslen commented Nov 18, 2023

@QuentinLemCode this adds rimraf to the build and test scripts as well as the package-lock.json
#616

@guslen
Copy link
Author

guslen commented Nov 18, 2023

@QuentinLemCode this takes care of the workflows #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants