feat: cache s key prefix configuration #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezerdemello thanks for the pull request. I would recommend you add this value to options instead of adding another. |
|
Ok!! I'll change and submit the branch. Thanks.
Em dom., 21 de abr. de 2024 13:54, Jared Wray ***@***.***>
escreveu:
… @ezerdemello <https://github.com/ezerdemello> thanks for the pull
request. I would recommend you add this value to options instead of adding
another.
—
Reply to this email directly, view it on GitHub
<#666 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AINJ3YKDO3TWB3VVY5HBWNTY6PVMDAVCNFSM6AAAAABGOOLXNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGEZTGMRSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ezerdemello - great. Let me know when the change is ready. |
|
Hey Jared Wray,
i think that its done! Anything else send new message for me
bye!
Em ter., 23 de abr. de 2024 às 12:24, Jared Wray ***@***.***>
escreveu:
… @ezerdemello <https://github.com/ezerdemello> - great. Let me know when
the change is ready.
—
Reply to this email directly, view it on GitHub
<#666 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AINJ3YIMXXE5WOMSOCZR6DTY6Z4KNAVCNFSM6AAAAABGOOLXNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSGY4DSNZRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ezerdemello - There are two things we need. The main thing is we need to get a unit test to validate this. Can you submit that? if you do I can add in the documentation for this. Thanks! |
|
This will be a nice addition @ezerdemello @jaredwray , I found myself implementing this in a custom store and having it baked into the interface will be superior. 🙇 |
|
@ezerdemello and @zph - Agreed and the last updates I can do if they arent done earlier in a week or so then will deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Includes new configuration option for create cache's keys prefix if this option is informed. If this new configuration option didn't setup nothing happens.