Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add details to error event #682

Merged
merged 4 commits into from
May 9, 2024

Conversation

corradodellorusso
Copy link
Contributor

@corradodellorusso corradodellorusso commented May 6, 2024

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
When using caching.on and multicaching.on, there's no way to:

  • Know the circumstances that caused the error (key, data, operation, etc...)
  • Unsubscribe from the emitter

Introducing this changes, consumers can better monitor and classify errors.

@jaredwray
Copy link
Owner

@corradodellorusso looks like xo is catching some lint errors.

@corradodellorusso
Copy link
Contributor Author

@jaredwray should be fixed now.

@jaredwray jaredwray merged commit 7677261 into jaredwray:main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants