Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added animation type for RN Modal #145

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JNelder
Copy link

@JNelder JNelder commented Mar 31, 2022

No description provided.

@RyanPliske
Copy link

RyanPliske commented Sep 12, 2023

for those of you looking for a way around this. I was able to get this to work:

class CustomModal extends Modal {
  render(): React.ReactNode {
    // eslint-disable-next-line react/jsx-props-no-spreading
    return <Modal {...this.props} animationType="fade" />
  }
}
<Tooltip
   modalComponent={CustomModal}
>

Copy link
Owner

@jasongaare jasongaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough, let's change the defaultProp and we are good to go

@@ -75,6 +75,7 @@ class Tooltip extends Component {
useReactNativeModal: true,
topAdjustment: 0,
accessible: true,
animationType: 'fade',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current default is 'none' could you update this so it is backward compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants