Skip custom click behavior on links when the download attribute is set

The presumption here is that if an A node has a download attribute explicitly set, the user really does want to download the file rather than opening the file in JLab. Fixes jupyterlab#5443
jasongrout · Oct 10, 2019 · 2d23e79 · 2d23e79
1 parent 1293dd2
commit 2d23e79
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/rendermime-extension/src/index.ts b/packages/rendermime-extension/src/index.ts
@@ -80,6 +80,11 @@ function activate(
       ? null
       : {
           handleLink: (node: HTMLElement, path: string, id?: string) => {
+            // If node has the download attribute explicitly set, use the
+            // default browser downloading behavior.
+            if (node.tagName === 'A' && node.hasAttribute('download')) {
+              return;
+            }
             app.commandLinker.connectNode(node, CommandIDs.handleLink, {
               path,
               id

diff --git a/packages/rendermime-interfaces/src/index.ts b/packages/rendermime-interfaces/src/index.ts
@@ -320,7 +320,7 @@ export namespace IRenderMime {
     /**
      * Add the link handler to the node.
      *
-     * @param node: the node for which to handle the link.
+     * @param node: the anchor node for which to handle the link.
      *
      * @param path: the path to open when the link is clicked.
      *