Disable type checking vega-lite libraries.

Typscript 3.7 throws some errors when compiling Vega-lite 2 and 3, so we turn off lib checks. This was investigated much more deeply in jupyterlab#7428, where we deleted the vega 4 extension and upgraded the vega 5 extension to vega-lite 4.0b11. The vega-lite upgrade was not going smoothly, so we moved it to a separate issue and redid the Typescript upgrade by just using the skipLibCheck flag.
jasongrout · Nov 14, 2019 · 4029c13 · 4029c13
1 parent 6bfe84f
commit 4029c13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/packages/vega4-extension/tsconfig.json b/packages/vega4-extension/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "outDir": "lib",
+    "skipLibCheck": true,
     "types": ["webpack-env"],
     "rootDir": "src"
   },

diff --git a/packages/vega5-extension/tsconfig.json b/packages/vega5-extension/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "outDir": "lib",
+    "skipLibCheck": true,
     "types": ["webpack-env"],
     "rootDir": "src"
   },