Skip to content

Commit

Permalink
Merge pull request jupyterlab#7243 from jasongrout/releasescripts2
Browse files Browse the repository at this point in the history
Use temp directories and error handling better in release process and release testing.
  • Loading branch information
jasongrout committed Oct 10, 2019
2 parents 6d0882f + 6f72aec commit 4cead36
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion RELEASE.md
Expand Up @@ -98,7 +98,7 @@ If there is a network error during JS publish, run `npm run publish:all --skip-b

Note that the use of `npm` instead of `jlpm` is [significant on Windows](https://github.com/jupyterlab/jupyterlab/issues/6733).

At this point, run the `source scripts/release_test.sh` to test the wheel in
At this point, run the `./scripts/release_test.sh` to test the wheel in
a fresh conda environment with and without extensions installed. Open and run
the Outputs notebook and verify everything runs properly. Also add a cell with the following code and make sure the widget renders:

Expand Down
5 changes: 1 addition & 4 deletions scripts/release_prep.sh 100644 → 100755
Expand Up @@ -6,12 +6,9 @@ else
JLAB_REL_BRANCH=$1
JLAB_REL_ENV=jlabrelease_$JLAB_REL_BRANCH

WORK_DIR=$(mktemp -d)
WORK_DIR=$(mktemp -d -t $JLAB_REL_ENV)
cd $WORK_DIR

conda deactivate
conda remove --all -y -n $JLAB_REL_ENV

conda create --override-channels --strict-channel-priority -c conda-forge -c anaconda -y -n $JLAB_REL_ENV notebook nodejs twine
conda activate $JLAB_REL_ENV

Expand Down
7 changes: 3 additions & 4 deletions scripts/release_test.sh 100644 → 100755
@@ -1,17 +1,16 @@
# Test a release wheel in a fresh conda environment with and without installed
# extensions
set -v
set -x
set -e
old="${CONDA_DEFAULT_ENV}"
JLAB_TEST_ENV="${CONDA_DEFAULT_ENV}_test"
TEST_DIR="$WORK_DIR/test"
TEST_DIR=$(mktemp -d -t $JLAB_TEST_ENV)

conda create --override-channels --strict-channel-priority -c conda-forge -c anaconda -y -n "$JLAB_TEST_ENV" notebook nodejs twine
conda activate "$JLAB_TEST_ENV"

pip install dist/*.whl


mkdir -p $TEST_DIR
cp examples/notebooks/*.ipynb $TEST_DIR/
pushd $TEST_DIR

Expand Down

0 comments on commit 4cead36

Please sign in to comment.