Upgrade to newer form-data SSR error

[philosofonusus]

I have an preact SSR application and when I try to build it preact build I recieve:

Unable to read file: /node_modules/graphql-request/node_modules/form-data/lib/browser.js

ReferenceError: window is not defined
method: oYKm

package form-data fixed this issue here form-data/form-data#496

Since the SSR does not have a window-object we need to check that it exists, no requests are performed on the server but the rendering will complain about this use of the window-variable.

the solution to this is here, and they have added fix

module.exports = typeof self == 'object' ? self.FormData : typeof window !='undefined' ? window.FormData : undefined;

So please upgrade to newer version of form-data

[mrosata]

It would be nice not to include packages that write to the global object period. Easier said than done because it's not something one typically finds out about until things break.. but packages like this are often included in other packages, which causes a big old pain chain.

[mrosata]

@jasonkuhrt I ran

pnpm upgrade form-data@4.0.0
pnpm run test

locally and all the tests passed. Is it possible to make and release this change?

[WesleyKapow]

NOTE: form-data/form-data#496 has not been merged in yet.

I got this working by patching node_modules/form-data/lib/browser.js as shown in the above PR and using https://github.com/ds300/patch-package to create and apply the patch.

You can also override the form-data dependency via:

  "overrides": {
    "form-data": "4.0.0"
  },

But note, this isn't sufficient yet as form-data has yet to merge in the fix, thus the need for the patch!

[jasonkuhrt]

Fixed by #501.