Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache API calls to fetch watching repos #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Oct 26, 2021

This change improves the performance of SystemStreamWatchingClient.buildSearchQueries.

Problem

SystemStreamWatchingClient.buildSearchQueries is a bottleneck in my environment because I have 1000+ watching repositories so it calls the API 10+ times.
buildSearchQueries is called for each iteration, which means it is called many times.

Solution

Cache the API calls. By this change, buildSearchQueries returns from the cache, and the cache expires in 10 minutes.

It has also a disadvantage, which it introduces a 10mins delay to update the watching repositories.
But I think it is not a problem. Probably, the users don't expect to synchronize the watching repositories immediately. So the delay is acceptable.

This change has a large impact on me. I'd be very happy if this change is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant