Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Conditional Operator resolution [JLS 15.25] #3522

Merged
merged 3 commits into from Mar 20, 2022

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Mar 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #3522 (333177b) into master (c9987c9) will increase coverage by 0.026%.
The diff coverage is 71.604%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3522       +/-   ##
===============================================
+ Coverage     58.217%   58.244%   +0.026%     
- Complexity      2636      2652       +16     
===============================================
  Files            628       632        +4     
  Lines          34309     34328       +19     
  Branches        5847      5837       -10     
===============================================
+ Hits           19974     19994       +20     
- Misses         12289     12290        +1     
+ Partials        2046      2044        -2     
Flag Coverage Δ
AlsoSlowTests 58.244% <71.604%> (+0.026%) ⬆️
javaparser-core 53.822% <ø> (ø)
javaparser-symbol-solver 35.991% <71.604%> (+0.038%) ⬆️
jdk-10 58.236% <71.604%> (+0.026%) ⬆️
jdk-11 58.236% <71.604%> (+0.026%) ⬆️
jdk-12 58.236% <71.604%> (+0.031%) ⬆️
jdk-13 58.236% <71.604%> (+0.031%) ⬆️
jdk-14 58.236% <71.604%> (+0.026%) ⬆️
jdk-15 58.231% <71.604%> (+0.020%) ⬆️
jdk-16 58.236% <71.604%> (+0.026%) ⬆️
jdk-8 58.241% <71.604%> (+0.026%) ⬆️
jdk-9 58.236% <71.604%> (+0.026%) ⬆️
macos-latest 58.235% <71.604%> (+0.026%) ⬆️
ubuntu-latest 58.229% <71.604%> (+0.026%) ⬆️
windows-latest 58.226% <71.604%> (+0.026%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...parser/resolution/types/ResolvedPrimitiveType.java 94.736% <ø> (ø)
...ution/promotion/NumericConditionalExprHandler.java 64.814% <64.814%> (ø)
...ution/promotion/BooleanConditionalExprHandler.java 71.428% <71.428%> (ø)
.../resolution/promotion/ConditionalExprResolver.java 75.000% <75.000%> (ø)
...er/symbolsolver/javaparsermodel/TypeExtractor.java 75.303% <100.000%> (+3.735%) ⬆️
...ion/promotion/ReferenceConditionalExprHandler.java 100.000% <100.000%> (ø)
...ava/com/github/javaparser/ast/expr/Expression.java 15.697% <0.000%> (-1.163%) ⬇️
...om/github/javaparser/ast/expr/ConditionalExpr.java 47.619% <0.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9987c9...333177b. Read the comment docs.

@jlerbsc jlerbsc merged commit 79e4b51 into javaparser:master Mar 20, 2022
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Mar 20, 2022
@jlerbsc jlerbsc added this to the next release milestone Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant