Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3631 NameExpr.resolve() does not take end of inner block scopes into account #3613

Merged
merged 5 commits into from Jul 8, 2022

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Jun 13, 2022

Fixes #3631 .

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3613 (5a58cf3) into master (c52c538) will increase coverage by 0.002%.
The diff coverage is 43.750%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3613       +/-   ##
===============================================
+ Coverage     58.332%   58.334%   +0.002%     
- Complexity      2660      2661        +1     
===============================================
  Files            633       633               
  Lines          34348     34350        +2     
  Branches        5842      5843        +1     
===============================================
+ Hits           20036     20038        +2     
  Misses         12258     12258               
  Partials        2054      2054               
Flag Coverage Δ
AlsoSlowTests 58.334% <43.750%> (+0.002%) ⬆️
javaparser-core 53.842% <35.714%> (ø)
javaparser-symbol-solver 36.055% <25.000%> (+0.003%) ⬆️
jdk-10 58.324% <43.750%> (+0.005%) ⬆️
jdk-11 58.327% <43.750%> (+0.002%) ⬆️
jdk-12 58.324% <43.750%> (-0.001%) ⬇️
jdk-13 58.327% <43.750%> (+0.002%) ⬆️
jdk-14 58.321% <43.750%> (-0.004%) ⬇️
jdk-15 58.321% <43.750%> (-0.004%) ⬇️
jdk-16 58.327% <43.750%> (+0.002%) ⬆️
jdk-8 58.332% <43.750%> (+0.005%) ⬆️
jdk-9 58.327% <43.750%> (+0.002%) ⬆️
macos-latest 58.326% <43.750%> (+0.002%) ⬆️
ubuntu-latest 58.320% <43.750%> (+0.002%) ⬆️
windows-latest 58.317% <43.750%> (+0.002%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/main/java/com/github/javaparser/JavaToken.java 89.749% <ø> (ø)
...ub/javaparser/ast/comments/CommentsCollection.java 56.097% <0.000%> (ø)
...xicalpreservation/DifferenceElementCalculator.java 86.577% <0.000%> (ø)
.../lexicalpreservation/LexicalPreservingPrinter.java 73.475% <0.000%> (ø)
...mbolsolver/model/typesystem/ReferenceTypeImpl.java 85.046% <ø> (ø)
...ava/com/github/javaparser/utils/PositionUtils.java 71.604% <50.000%> (ø)
.../github/javaparser/printer/PrettyPrintVisitor.java 20.452% <100.000%> (ø)
...ver/javaparsermodel/contexts/StatementContext.java 66.666% <100.000%> (+0.595%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52c538...5a58cf3. Read the comment docs.

@jlerbsc jlerbsc added this to the next release milestone Jun 13, 2022
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Jun 13, 2022
@jlerbsc jlerbsc changed the title Minor refactoring - generalization of the use of the hasrange method Fix issue 3631 NameExpr.resolve() does not take end of inner block sc… 5a58cf3 …opes into account Jul 8, 2022
@jlerbsc jlerbsc changed the title Fix issue 3631 NameExpr.resolve() does not take end of inner block sc… 5a58cf3 …opes into account Fix issue 3631 NameExpr.resolve() does not take end of inner block scopes into account Jul 8, 2022
@jlerbsc jlerbsc merged commit a8eaeb3 into javaparser:master Jul 8, 2022
@jlerbsc jlerbsc added PR: Fixed A PR that offers a fix or correction and removed PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameExpr.resolve() does not take end of inner block scopes into account
1 participant