Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3415 #3722

Merged
merged 3 commits into from Oct 19, 2022
Merged

Issue #3415 #3722

merged 3 commits into from Oct 19, 2022

Conversation

nelson-ng-96
Copy link
Contributor

Added deprecated for the method getConfiguration to fix issue #3415.

@nelson-ng-96 nelson-ng-96 reopened this Oct 19, 2022
@nelson-ng-96
Copy link
Contributor Author

Added a new method in StaticJavaParser which aligns with the method getParserConfiguration() naming in SourceRoot.
Made the deprecated method in StaticJavaParser to call the new method in StaticJavaParser.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #3722 (e56b3df) into master (b9a7d0f) will increase coverage by 0.004%.
The diff coverage is 100.000%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3722       +/-   ##
===============================================
+ Coverage     58.317%   58.321%   +0.004%     
  Complexity      2662      2662               
===============================================
  Files            633       633               
  Lines          34393     34394        +1     
  Branches        5847      5847               
===============================================
+ Hits           20057     20059        +2     
  Misses         12283     12283               
+ Partials        2053      2052        -1     
Flag Coverage Δ
AlsoSlowTests 58.321% <100.000%> (+0.004%) ⬆️
javaparser-core 53.836% <100.000%> (+0.001%) ⬆️
javaparser-symbol-solver 36.046% <100.000%> (+0.004%) ⬆️
jdk-10 58.314% <100.000%> (+0.009%) ⬆️
jdk-11 58.311% <100.000%> (+0.007%) ⬆️
jdk-12 58.314% <100.000%> (+0.004%) ⬆️
jdk-13 58.314% <100.000%> (+0.004%) ⬆️
jdk-14 58.314% <100.000%> (+0.004%) ⬆️
jdk-15 58.311% <100.000%> (+0.001%) ⬆️
jdk-16 58.311% <100.000%> (+0.001%) ⬆️
jdk-8 58.315% <100.000%> (+0.004%) ⬆️
jdk-9 58.311% <100.000%> (+0.001%) ⬆️
macos-latest 58.309% <100.000%> (+0.001%) ⬆️
ubuntu-latest 58.306% <100.000%> (+0.004%) ⬆️
windows-latest 58.300% <100.000%> (+0.001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/com/github/javaparser/StaticJavaParser.java 82.926% <100.000%> (+0.426%) ⬆️
...ava/com/github/javaparser/ParserConfiguration.java 90.647% <0.000%> (+0.719%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a7d0f...e56b3df. Read the comment docs.

@jlerbsc jlerbsc merged commit a06678f into javaparser:master Oct 19, 2022
@jlerbsc
Copy link
Collaborator

jlerbsc commented Oct 19, 2022

Thank you for this contribution.

@jlerbsc jlerbsc added this to the next release milestone Oct 19, 2022
@jlerbsc jlerbsc added the PR: Deprecation A PR that newly deprecates existing code label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Deprecation A PR that newly deprecates existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants