Update peerDependencies in package.json

[MichaelDeBoey]

https://twitter.com/SemanticRelease/status/1249795728253353986

[jaydenseric]

Thanks for the suggestion, but there are a few reasons not to do it this way.

[jaydenseric]

Sorry, pressed "Comment" early, reasons coming…

[jaydenseric]

Semver for peerDependencies should be quite similar conceptually for that of dependencies and devDependencies. If you did ">=0.12.3" in dependencies, when a future major version with breaking changes is out, you wouldn't want to automatically pull in those breaking changes. For peer dependencies, we don't want to automatically declare support for major versions with breaking changes.

Note that some package managers (including future npm) install peerDependencies automatically, and there are npx scripts and other utilities that install peer dependencies automatically. We need to be careful to only declare support for major versions know to be compatible.

Regarding the verbose syntax of the current value. Normally I use semver range syntax (-), instead of the verbose || chain:

https://github.com/jaydenseric/graphql-upload/blob/a3b7b31406aa47567ced0b60eea1cd764db8932c/package.json#L45

Although, in this case we matched exactly the peer dependency Apollo Client declares. This package doesn't actually use graphql; here is an explanation why the peer dep was recently added to this package: #196 .

[MichaelDeBoey]

@jaydenseric apollo-client just merged my PR (apollographql/apollo-client#6594) to do it in their repo too.

[jaydenseric]

Thanks for sharing, but I'm quite sure they've made a mistake.

[benjamn]

Yep, this was a mistake for Apollo Client. Thanks for the explanation @jaydenseric!