Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @apollo/client should be a peer dependency #252

Merged
merged 4 commits into from May 13, 2021

Conversation

andreialecu
Copy link
Contributor

Fixes #251

@jaydenseric
Copy link
Owner

Thanks for the issue and PR, I'll likely merge this but don't have the time to see it through today. It would be a semver major change, and I want to do a few maintenance things for the same release that might be a day or two of work. Once I finish dogfooding the coming new graphql-react in some large codebases and publish it I'll have a chance to catch up on things like this PR.

In the meantime, as discussed in #251, multiple installations of apollo-upload-client can be avoided by ensuring only one version is specified in the project lockfile. Deduping dependencies in a lockfile is something everyone should always do anyway, or you will end up with massively bloated node_modules and bundles. I always delete my lockfile and regenerate it from scratch when updating dependencies to avoid bloat, although as you mentioned in the issue there are other ways to do more targeted updates with deduping.

package.json Outdated Show resolved Hide resolved
@jaydenseric jaydenseric merged commit a1f6d52 into jaydenseric:master May 13, 2021
@jaydenseric
Copy link
Owner

Thanks for your work, this change has been published in v15 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@apollo/client should be a peer dependency
2 participants