New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to fs-capacitor v4 #166
Merged
Merged
Commits on Nov 2, 2019
-
Upgrade to fs-capacitor v4 beta
I've done a rework of fs-capacitor to support node 13. This involved using the `readable-stream` package instead of node's stream library in order to simply continued compatibility with node v8.x, which we can drop at the end of 2019. I spent the better part of a day trying to figure out exporting interoperable es6 and commonjs modules now that I have a commonjs dependency, and I finally just gave up. Without any useful guidance or pathway put forward by node for interoperability, the only choice here is to chose a single module system, which will be commonjs for the immediate future. I'm very unhappy with this situation and fear this is going to severly fragment the ecosystem, but don't have the time to get involved any further.
-
-
-
-
-
-
Commits on Nov 4, 2019
Commits on Nov 12, 2019
Commits on Nov 17, 2019
Commits on Nov 18, 2019
-
Merge branch 'master' into fs-capacitor-4
I also fixed up the changelog entry. # Conflicts: # .github/workflows/ci.yml # package.json
-
I removed tests that checked for cleanup of internal files used by fs-capacitorr. These tests required hooks into internal details of the library and are really outside the scope of concerns for this project.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.