Skip to content

Commit

Permalink
Temporarily disable tests for Node.js v18.
Browse files Browse the repository at this point in the history
TODO: Re-enable these tests in Node.js v18 once the fix for this Node.js test runner bug is published in a v18 release:

nodejs/node#48845

The Node.js v18.19.0 release is scheduled for 2023-11-28:

nodejs/Release#737
  • Loading branch information
jaydenseric committed Nov 21, 2023
1 parent 8e6c583 commit 6de1cbc
Show file tree
Hide file tree
Showing 2 changed files with 300 additions and 294 deletions.
3 changes: 2 additions & 1 deletion changelog.md
Expand Up @@ -22,7 +22,8 @@
- Updated `actions/checkout` to v4.
- Updated `actions/setup-node` to v4.
- Fixed the types for test fixture Next.js config.
- In tests:
- For the function `withGraphQLReact` tests:
- Temporarily disabled the tests for Node.js v18 due to the Node.js test runner bug [nodejs/node#48845](https://github.com/nodejs/node/issues/48845) that will be fixed in a future Node.js v18 release.
- Use the new Puppeteer headless mode.
- For the client side page load test:
- Attempt to wait until the JS has loaded and the React app has mounted before clicking the navigation link.
Expand Down

0 comments on commit 6de1cbc

Please sign in to comment.