Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blacklist view to log out users #306

Merged
merged 4 commits into from
Oct 1, 2021

Conversation

hodossy
Copy link
Contributor

@hodossy hodossy commented Sep 24, 2020

Thanks for this great library! I would like to contribute to this project with a view to effectively log out users. Currently the only way of doing it is by manually blacklisting the corresponding token. However, if a user whishes to log out, the server should invalidate the refresh token triggered by a logout request. This PR aims to fill in that gap. Many thanks for your feedback!

@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Sep 25, 2020

Hey @hodossy ! Thanks for contributing! Please add some tests so that we know a token is actually invalid. Being a security library, we want to look for anything that can result in bad stuff. Scratch that! GitHub notif just showed me one commit! My bad.

I haven't had the time to take a look back at this repo in awhile (still awaiting response from David to push new version out). One of the big issues lately seems to be the blacklist app, so you'll have to wait once you finish creating those tests. Ref above comment I think, before David pushes out a new version, this can also be included since #71 is going to take awhile to finish reviewing.

Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hope you don't mind, but I'm going to let @davesque review this one, as well, before merging just in case I'm missed something in my review. Thanks for the PR @hodossy!

@hodossy
Copy link
Contributor Author

hodossy commented Nov 11, 2021

Thanks guys for merging this!

@Andrew-Chen-Wang
Copy link
Member

Thanks for the addition!

@LavenderMP
Copy link

@hodossy Could you tell me how to use log out feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants